Skip to content

Conversation

@ognevny
Copy link
Contributor

@ognevny ognevny commented Dec 22, 2024

this applies a fix for windows-gnullvm targets

this applies a fix for windows-gnullvm targets
@ognevny ognevny requested a review from a team as a code owner December 22, 2024 08:09
@ognevny ognevny requested review from alexcrichton and removed request for a team December 22, 2024 08:09
@ognevny
Copy link
Contributor Author

ognevny commented Dec 22, 2024

I don't understand CI failure :(

@alexcrichton
Copy link
Member

Thanks for the PR! This is holiday season for a number of maintainers (including myself) so it'll be a week or two before I can review this at least. There's some more information about dependencies of wasmtime here if you're interested in the meantime though.

@alexcrichton
Copy link
Member

The CI error here was because of the missing vet entries which maintainers manage as opposed to authors. I've added the vets here and once CI finishes this'll make its way to the merge queue. Thanks again for this!

@alexcrichton alexcrichton enabled auto-merge January 6, 2025 15:54
@ognevny
Copy link
Contributor Author

ognevny commented Jan 6, 2025

thank you

@alexcrichton alexcrichton added this pull request to the merge queue Jan 6, 2025
Merged via the queue into bytecodealliance:main with commit dd2365e Jan 6, 2025
39 checks passed
@ognevny ognevny deleted the update-cc branch January 6, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants